Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depbot: bump github.com/k8snetworkplumbingwg/network-attachment-definition-client from 1.4.0 to 1.7.4 #2054

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 1, 2024

Bumps github.com/k8snetworkplumbingwg/network-attachment-definition-client from 1.4.0 to 1.7.4.

Release notes

Sourced from github.com/k8snetworkplumbingwg/network-attachment-definition-client's releases.

v1.7.4

This release accounts for CNI plugins which do not use the sandbox field in results when calculating the network-status annotation, doing so for backwards compatibility for plugins which choose to not use this field (such as Calico)

v1.7.3

This release accounts for the sandox interfaces when reporting the interfaces in the network-status annotation; in case the CreateNetworkStatuses clients invoke it with a CNI result featuring non-sandbox interfaces as the first item in the list, this release accounts for that condition.

v1.7.2

When the CreateNetworkStatuses method was created to properly set the network-status annotation when a CNI result includes multiple interfaces in the return, it was found that it when setting the "default" parameter in the network-status, it was setting it to all the returned interfaces to true, which doesn't fit the NPWG net-attach-def specification.

This release fixes that issue by using the first interface in the CNI result set to "default": true for the cluster default network and not the following interfaces.

NOTE Do not use this version, use >= v1.7.3

v1.7.1

Adds the CreateNetworkStatuses method to properly set the network-status annotation when a CNI result includes multiple interfaces in the return.

For details of the before/after, see this gist: https://gist.github.com/dougbtv/1eb8ac2d61d494b56d65a6b236a86e61

For the related suggested update to the NPWG net-attach-def specification (for clarity only), see this proposal @ https://docs.google.com/document/d/1DUTV-o6E6zlRTKZkxeDhAeyGrmq03qPgPbU580Rm7-g/edit

v1.7.0

Adds MTU to network-status

v1.6.0

Adds IPAMClaimReference to network-selection-elements

v1.5.0

What's Changed

New Contributors

Full Changelog: k8snetworkplumbingwg/network-attachment-definition-client@v1.4.0...v1.5.0

Commits
  • 9b218a2 Merge pull request #72 from maiqueb/address-calico-not-defining-sandbox
  • ed6baad Preserve backwards compatibility of CreateNetworkStatus
  • 506cfda Merge pull request #71 from maiqueb/account-for-sandbox-ifaces-when-choosing-...
  • d8782ff Accont for non-sandbox interfaces when specifying the default network
  • d23f60f Merge pull request #70 from maiqueb/multiple-default-interfaces
  • afe49cd Comply with de-facto standar for multiple interfaces single ADD request
  • ec02fb3 Merge pull request #68 from dougbtv/networkstatus-multiple-interface-result
  • 38ceddc Adds CreateNetworkStatuses method which will handle CNI results with multiple...
  • e1583b6 Merge pull request #66 from k8snetworkplumbingwg/dependabot/go_modules/golang...
  • 5492daa Bump golang.org/x/net from 0.17.0 to 0.23.0
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

…ition-client

Bumps [github.com/k8snetworkplumbingwg/network-attachment-definition-client](https://github.com/k8snetworkplumbingwg/network-attachment-definition-client) from 1.4.0 to 1.7.4.
- [Release notes](https://github.com/k8snetworkplumbingwg/network-attachment-definition-client/releases)
- [Commits](k8snetworkplumbingwg/network-attachment-definition-client@v1.4.0...v1.7.4)

---
updated-dependencies:
- dependency-name: github.com/k8snetworkplumbingwg/network-attachment-definition-client
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
Once this PR has been reviewed and has the lgtm label, please assign ffromani for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 1, 2024
Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zeeke
Copy link
Member

zeeke commented Oct 1, 2024

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 1, 2024
@zeeke
Copy link
Member

zeeke commented Oct 2, 2024

/retest

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 15, 2024

Superseded by #2069.

@dependabot dependabot bot closed this Oct 15, 2024
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/k8snetworkplumbingwg/network-attachment-definition-client-1.7.4 branch October 15, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants