Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNF-14823: Enforce reference and source-crs synchronization via CI #2070

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

CNF-14823: Enforce reference and source-crs synchronization via CI #2070

wants to merge 2 commits into from

Conversation

lack
Copy link
Member

@lack lack commented Oct 15, 2024

  • ztp: reference: enforce source-cr and reference alignment in CI
  • ztp: Introduce 'make sync' to synchronize reference -> source-crs

@lack
ztp: reference: enforce source-cr and reference alignment in CI
9162ea3 
Signed-off-by: Jim Ramsay <[email protected]>
@lack
ztp: Introduce 'make sync' to synchronize reference -> source-crs
c793ba3 
Note: This overwrites source-crs, so you may lose work if you've edited
source-crs content.

Signed-off-by: Jim Ramsay <[email protected]>
@openshift-ci-robot
Copy link
Collaborator

@lack: This pull request references CNF-14823 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

  • ztp: reference: enforce source-cr and reference alignment in CI
  • ztp: Introduce 'make sync' to synchronize reference -> source-crs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 15, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2024
@lack
Copy link
Member Author

lack commented Oct 16, 2024

/cc @imiller0 @nocturnalastro @natifridman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imiller0 imiller0 Awaiting requested review from imiller0

@natifridman natifridman Awaiting requested review from natifridman

@nocturnalastro nocturnalastro Awaiting requested review from nocturnalastro

@kenyis kenyis Awaiting requested review from kenyis

@sabbir-47 sabbir-47 Awaiting requested review from sabbir-47

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ztp/reference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lack @openshift-ci-robot