Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ztp: CNF-14991: Fix instability in policy-generator-plugin usage #2077

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ztp: CNF-14991: Fix instability in policy-generator-plugin usage #2077

wants to merge 2 commits into from

Conversation

fontivan
Copy link
Contributor

  • Specifically check for and use the exact policy-generator-plugin version used by ACM
  • When used in older branches the ACM_BRANCH value can be updated to match the appropriate ACM version in use in that release
  • Fixed tmp dir not getting cleaned up due to incorrect working directory when rm was called
  • Add .gitignore entry for built kustomize files

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 18, 2024
@openshift-ci-robot
Copy link
Collaborator

@fontivan: This pull request references CNF-14991 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

  • Specifically check for and use the exact policy-generator-plugin version used by ACM
  • When used in older branches the ACM_BRANCH value can be updated to match the appropriate ACM version in use in that release
  • Fixed tmp dir not getting cleaned up due to incorrect working directory when rm was called
  • Add .gitignore entry for built kustomize files

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@fontivan
Copy link
Contributor Author

/cc @imiller0 @lack @sabbir-47 @edcdavid

@fontivan
ztp: CNF-14991: Fix instability in policy-generator-plugin usage
ffeb755 
- Specifically check for and use the exact policy-generator-plugin version used by ACM
- When used in older branches the ACM_BRANCH value can be updated to match the appropriate ACM version in use in that release
- Fixed tmp dir not getting cleaned up due to incorrect working directory when rm was called
- Add .gitignore entry for built kustomize files
@fontivan fontivan force-pushed the sskeard/stable-policy-generator-plugin branch from ac10eac to ffeb755 Compare October 18, 2024 20:49
@fontivan fontivan changed the title infra: CNF-14991: Fix instability in policy-generator-plugin usage ztp: CNF-14991: Fix instability in policy-generator-plugin usage Oct 18, 2024
edcdavid
edcdavid approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@edcdavid edcdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this issue.

ztp/tools/pgt2acmpg/scripts/build-acmpg-plugin.sh Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: edcdavid, fontivan
Once this PR has been reviewed and has the lgtm label, please assign ijolliffe for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edcdavid edcdavid edcdavid approved these changes

@mmirecki mmirecki Awaiting requested review from mmirecki

@yuvalk yuvalk Awaiting requested review from yuvalk

@imiller0 imiller0 Awaiting requested review from imiller0

@lack lack Awaiting requested review from lack

@sabbir-47 sabbir-47 Awaiting requested review from sabbir-47

Assignees

@edcdavid edcdavid

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fontivan @openshift-ci-robot @edcdavid