drop openshift-sdn references #2057
Conversation
openshift-ci-robot
added
the
backports/unvalidated-commits
|
@danwinship: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: danwinship The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@danwinship: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/assign @atiratree |
OpenShift SDN is no longer present in OCP so we don't need skip rules for it.
It was still skipping [Skipped:Network/OpenShiftSDN] even though the tests use ovn-kubernetes now. The only test that is currently marked [Skipped:Network/OVNKubernetes] was also marked [Skipped:Network/OpenShiftSDN], which is why it still worked, but this meant that we were skipping other tests that _shouldn't_ have been skipped on ovn-k. (Of course, any problems that resulted from this would be caught in other e2es later, so this wasn't actually permanently masking any problems.)
|
@danwinship: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/retest |
|
@danwinship: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
mostly just cleanup
(there's also a bug in test-kubernetes-e2e.sh but it doesn't matter that much)