OCPBUGS-39175: [release-4.14] Leap event 4.14 #356
Conversation
This adds automatic leap file updates from GPS data. Signed-off-by: Vitaly Grinberg <[email protected]>
This fixes a bug causing leap file expiration date to be off by 70 years and update date to be outdated Signed-off-by: Vitaly Grinberg <[email protected]>
Signed-off-by: Aneesh Puttur <[email protected]>
This commit fixes various leap file corner cases and adds missing functionality: 1. Rehash the leapfile after setting the expiration time to 2036 2. Fix corner cases of leap event appearing in a different ways in the leap indication in the past or in the future + add unit tests 3. General cleanup and refactor for better testability 4. Add unit tests Signed-off-by: Vitaly Grinberg <[email protected]>
This PR fixes a bug where the daemon wrote uninitialized values to the time properties dataset, which led to corrupting the ptp time scale, current UTC offset and other dataset properties. The fix is done by always initializing the time properties according to the current UTC offset and a predefined set of flags. Leap manager was changed to provide current UTC offset to external packages. Signed-off-by: Vitaly Grinberg <[email protected]>
Signed-off-by: Aneesh Puttur <[email protected]>
openshift-ci-robot
added
jira/valid-reference
|
@vitus133: This pull request references Jira Issue OCPBUGS-39175, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vitus133 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
vitus133
force-pushed
the
leap-event-4.14
branch
3 times, most recently
from
92f20bc
to
2d52f38
Compare
this commit adds leap event handling that includes following: 1. Determine that current time is within -12h...1m from the leap 2. Send PMC command (once) to indicate leap61 or leap 59 to the downstream architecture and 3. Handle ts2phc time ambiguity Signed-off-by: Vitaly Grinberg <[email protected]>
vitus133
force-pushed
the
leap-event-4.14
branch
from
2d52f38
to
28a04f0
Compare
|
@vitus133: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
openshift-ci
bot
assigned anuragthehatter, asood-rh, gsr-shanks, huiran0826, jechen0648, mffiedler and obochan-rh
This is a manual cherry-pick of #326, #342 and #358
/cc @aneeshkp @jzding @josephdrichard @nishant-parekh