Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-43510: Incorrect Clock Class Transition Behavior in T-GM and PTP Holdover States #371

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aneeshkp
Copy link
Contributor

This PR does not address the issue of Clock Class being out of spec for the Time Grandmaster (T-GM) with SyncE. However, it introduces a fix to transition the clock state from HOLDOVER to FREERUN when an out-of-spec state is detected.
Key Changes:

Scenario:
    T-GM → GNSS Loss → Clock Class 7 (in Holdover)
    Out-of-spec state detected → Transition to FREERUN with Clock Class 248

Note:
    SyncE implementation requires Out-of-Spec Holdover, which is not supported in this PR. Further work will be needed to handle this specific SyncE case.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Oct 17, 2024
@openshift-ci-robot
Copy link
Contributor

@aneeshkp: This pull request references Jira Issue OCPBUGS-43510, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR does not address the issue of Clock Class being out of spec for the Time Grandmaster (T-GM) with SyncE. However, it introduces a fix to transition the clock state from HOLDOVER to FREERUN when an out-of-spec state is detected.
Key Changes:

Scenario:
T-GM → GNSS Loss → Clock Class 7 (in Holdover)
Out-of-spec state detected → Transition to FREERUN with Clock Class 248

Note:
SyncE implementation requires Out-of-Spec Holdover, which is not supported in this PR. Further work will be needed to handle this specific SyncE case.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 17, 2024
Copy link
Contributor

openshift-ci bot commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2024
Signed-off-by: Aneesh Puttur <[email protected]>
Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

@aneeshkp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants