-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COS-2959: Add rhel-9.6 and ocp-rhel-9.6 variants #1629
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbtrystram The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0e00216
to
70ea386
Compare
manifest-rhel-9.6.yaml
Outdated
cat > /usr/lib/os-release <<EOF | ||
NAME="Red Hat Enterprise Linux" | ||
VERSION="9.6 (Plow)" | ||
ID="rhel" | ||
ID_LIKE="fedora" | ||
VERSION="${OSTREE_VERSION}" | ||
VARIANT="CoreOS" | ||
VARIANT_ID=coreos | ||
VERSION_ID="9.6" | ||
PLATFORM_ID="platform:el9" | ||
PRETTY_NAME="${NAME} CoreOS ${OSTREE_VERSION}" | ||
ANSI_COLOR="0;31" | ||
LOGO="fedora-logo-icon" | ||
CPE_NAME="cpe:/o:redhat:enterprise_linux:9::coreos" | ||
HOME_URL="https://www.redhat.com/" | ||
DOCUMENTATION_URL="https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/9" | ||
BUG_REPORT_URL="https://issues.redhat.com/" | ||
|
||
REDHAT_BUGZILLA_PRODUCT="Red Hat Enterprise Linux 9" | ||
REDHAT_BUGZILLA_PRODUCT_VERSION=9.6 | ||
REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux" | ||
REDHAT_SUPPORT_PRODUCT_VERSION="9.6" | ||
EOF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you show the resulting /etc/os-release
file in the built container image/VM? Compare to https://gist.github.com/jlebon/908e45c42ce9e365fb83d7470cbbb40c for how it currently looks for rhel-9.4
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just updated to have something that matches :
NAME="Red Hat Enterprise Linux CoreOS"
VERSION="9.6.202410031540-0 (Plow)"
ID="rhel"
ID_LIKE="fedora"
VERSION="9.6.202410031540-0"
VARIANT="CoreOS"
VARIANT_ID=coreos
VERSION_ID="9.6"
PLATFORM_ID="platform:el9"
PRETTY_NAME="Red Hat Enterprise Linux CoreOS 9.6.202410031540-0 (Plow)"
ANSI_COLOR="0;31"
LOGO="fedora-logo-icon"
CPE_NAME="cpe:/o:redhat:enterprise_linux:9::baseos"
HOME_URL="https://www.redhat.com/"
DOCUMENTATION_URL="https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/9"
BUG_REPORT_URL="https://issues.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Red Hat Enterprise Linux 9"
REDHAT_BUGZILLA_PRODUCT_VERSION=9.6
REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="9.6"
OSTREE_VERSION="9.6.202410031540-0"
70ea386
to
4707c1a
Compare
/retest |
4707c1a
to
1176c70
Compare
/hold |
7de46d2
to
50c78e2
Compare
Right now these are pure centOS Stream 9 builds with a spoofed `os-release` file. For the ocp variant, pull the packages from the 9.4-4.18 repos. https://issues.redhat.com/browse/COS-2959
50c78e2
to
96503ef
Compare
1092eb9
to
ca926b1
Compare
This 9.6 rhel version is faked from centOS stream 9 so those tests are expected to fail. See openshift#1635
This brings teamd which is a required package for `ext.confg.network.team-dhcp-via-ignition`
ca926b1
to
810c9af
Compare
@jbtrystram: This pull request references COS-2959 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
secureboot does not work on c9s for now, so as this rhel 9.6 is just c9s, it won't either. denylist those tests until beta. This is the same as openshift@c95eedc
/unhold |
In preparation of rhel9.6 let's have prow entry points. https://issues.redhat.com/browse/COS-2975
Preparation work to update openshift/release jobs to build rhel 9.6 and c10s. Needs to be merged before openshift#1629 and openshift#1498
@jbtrystram: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
is the intention to squash these commits when ready to merge? |
# as it's a fake rhel build (from c9s) versions won't match | ||
- pattern: ext.config.version.rhel-major-version | ||
tracker: https://github.com/openshift/os/issues/1635 | ||
osversion: | ||
- rhel-9.6 | ||
- pattern: ext.config.shared.content-origins | ||
tracker: https://github.com/openshift/os/issues/1635 | ||
osversion: | ||
- rhel-9.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add a snooze to these so that we don't forget to start running the test?
I wish we could do it for all of the UEFI ones above but those have c9s
on them too.
Right now these are pure centOS Stream 9 builds with a spoofed
os-release
file.For the ocp variant, pull the packages from the 9.4-4.18 repos.
https://issues.redhat.com/browse/COS-2959