Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump to 4.18 and new 4.17 branch config #56058

Merged
merged 1 commit into from
Aug 30, 2024
Merged

bump to 4.18 and new 4.17 branch config #56058

merged 1 commit into from
Aug 30, 2024

Conversation

rauhersu
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 28, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 28, 2024

Hi @rauhersu. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rauhersu
Copy link
Contributor Author

Once we merge this, we must merge the following upstream ztp changes:

4.17: openshift-kni/cnf-features-deploy#2012
master: openshift-kni/cnf-features-deploy#2013

/cc @nishant-parekh

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@rauhersu: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kni-cnf-features-deploy-release-4.17-ci openshift-kni/cnf-features-deploy presubmit Presubmit changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.17-e2e-aws-ci-tests openshift-kni/cnf-features-deploy presubmit Presubmit changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.17-e2e-aws-ran-profile openshift-kni/cnf-features-deploy presubmit Presubmit changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.17-e2e-telco5g-cnftests openshift-kni/cnf-features-deploy presubmit Presubmit changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.17-e2e-telco5g-hcp-cnftests openshift-kni/cnf-features-deploy presubmit Presubmit changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.17-e2e-telco5g-sno-cnftests openshift-kni/cnf-features-deploy presubmit Presubmit changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.17-images openshift-kni/cnf-features-deploy presubmit Presubmit changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.17-security openshift-kni/cnf-features-deploy presubmit Presubmit changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.17-ztp-ci openshift-kni/cnf-features-deploy presubmit Presubmit changed
pull-ci-openshift-kni-cnf-features-deploy-master-ci openshift-kni/cnf-features-deploy presubmit Ci-operator config changed
pull-ci-openshift-kni-cnf-features-deploy-master-e2e-aws-ci-tests openshift-kni/cnf-features-deploy presubmit Ci-operator config changed
pull-ci-openshift-kni-cnf-features-deploy-master-e2e-aws-ran-profile openshift-kni/cnf-features-deploy presubmit Ci-operator config changed
pull-ci-openshift-kni-cnf-features-deploy-master-e2e-telco5g-cnftests openshift-kni/cnf-features-deploy presubmit Ci-operator config changed
pull-ci-openshift-kni-cnf-features-deploy-master-e2e-telco5g-hcp-cnftests openshift-kni/cnf-features-deploy presubmit Ci-operator config changed
pull-ci-openshift-kni-cnf-features-deploy-master-e2e-telco5g-sno-cnftests openshift-kni/cnf-features-deploy presubmit Ci-operator config changed
pull-ci-openshift-kni-cnf-features-deploy-master-images openshift-kni/cnf-features-deploy presubmit Ci-operator config changed
pull-ci-openshift-kni-cnf-features-deploy-master-security openshift-kni/cnf-features-deploy presubmit Ci-operator config changed
pull-ci-openshift-kni-cnf-features-deploy-master-ztp-ci openshift-kni/cnf-features-deploy presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

nishant-parekh
nishant-parekh reviewed Aug 28, 2024
View reviewed changes
core-services/image-mirroring/openshift-kni/mapping_openshift-kni_quay
@@ -86,7 +86,8 @@ registry.ci.openshift.org/ocp-kni/4.15:ztp-site-generator quay.io/openshift-kni/
registry.ci.openshift.org/ocp-kni/4.16:cnf-tests quay.io/openshift-kni/cnf-tests:4.16 quay.io/openshift-kni/cnf-tests:4.16.0 quay.io/openshift-kni/cnf-tests:latest
registry.ci.openshift.org/ocp-kni/4.16:dpdk quay.io/openshift-kni/dpdk:4.16 quay.io/openshift-kni/dpdk:4.16.0 quay.io/openshift-kni/dpdk:latest
registry.ci.openshift.org/ocp-kni/4.16:ztp-site-generator quay.io/openshift-kni/ztp-site-generator:4.16 quay.io/openshift-kni/ztp-site-generator:4.16.0
registry.ci.openshift.org/ocp-kni/4.17:ztp-site-generator quay.io/openshift-kni/ztp-site-generator:4.17 quay.io/openshift-kni/ztp-site-generator:4.17.0 quay.io/openshift-kni/ztp-site-generator:latest
registry.ci.openshift.org/ocp-kni/4.17:ztp-site-generator quay.io/openshift-kni/ztp-site-generator:4.17 quay.io/openshift-kni/ztp-site-generator:4.17.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rauhersu I think we need to bump the other images in this file as well or at least notify the folks to do this..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuvalk @rauhersu is going to notify the necessary folks to make the requested updates here once this change merges.. we discussed this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can consider this comment resolved for the PR merge perspective..

@nishant-parekh
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 28, 2024
nishant-parekh
nishant-parekh approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@nishant-parekh nishant-parekh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
@rauhersu one small comment to follow up with cnf-tests and dpdk owners to bump the image mapping for them too..

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2024
@rauhersu
Copy link
Contributor Author

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@rauhersu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

lack
lack approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@lack lack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@lack
Copy link
Contributor

lack commented Aug 29, 2024

I think the e2e-aws-ci-tests always fails, so those results look "good enough" to me.

@rauhersu
Copy link
Contributor Author

/retest

@rauhersu
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-kni-cnf-features-deploy-master-e2e-aws-ci-tests

@openshift-ci-robot
Copy link
Contributor

@rauhersu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@yuvalk
Copy link
Contributor

yuvalk commented Aug 29, 2024

came to approve, but I see there's an open comment
https://github.com/openshift/release/pull/56058/files#r1735119445

@yuvalk
Copy link
Contributor

yuvalk commented Aug 30, 2024

/approve

FYI @SchSeba and @sshnaidm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lack, nishant-parekh, rauhersu, yuvalk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2024
@rauhersu
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-kni-cnf-features-deploy-master-e2e-aws-ci-tests

@openshift-ci-robot
Copy link
Contributor

@rauhersu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@nishant-parekh
Copy link
Contributor

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@nishant-parekh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 30, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit caef84d into openshift:master Aug 30, 2024
19 of 22 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 30, 2024

@rauhersu: Updated the image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:

  • key mapping_openshift-kni_quay using file core-services/image-mirroring/openshift-kni/mapping_openshift-kni_quay

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

MiguelCarpio pushed a commit to MiguelCarpio/release that referenced this pull request Sep 4, 2024
@rauhersu @MiguelCarpio
bump to 4.18 and new 4.17 branch config (openshift#56058)
08a18bf
giladravid16 pushed a commit to giladravid16/release that referenced this pull request Sep 5, 2024
@rauhersu @giladravid16
bump to 4.18 and new 4.17 branch config (openshift#56058)
042bacb
MiguelCarpio pushed a commit to MiguelCarpio/release that referenced this pull request Sep 12, 2024
@rauhersu @MiguelCarpio
bump to 4.18 and new 4.17 branch config (openshift#56058)
1055610
obochan-rh pushed a commit to obochan-rh/release that referenced this pull request Sep 24, 2024
@rauhersu @obochan-rh
bump to 4.18 and new 4.17 branch config (openshift#56058)
63c5350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishant-parekh nishant-parekh nishant-parekh approved these changes

@lack lack lack approved these changes

@josephdrichard josephdrichard Awaiting requested review from josephdrichard

Assignees

@lack lack

@nishant-parekh nishant-parekh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rauhersu @openshift-ci-robot @nishant-parekh @lack @yuvalk