Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovn-k: add presubmit for virt #57947

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

ovn-k: add presubmit for virt #57947

wants to merge 5 commits into from

Conversation

qinqon
Copy link
Contributor

@qinqon qinqon commented Oct 17, 2024 •
edited
Loading

This PR add the new ovn-kubernetes virt presubmit job to origin as optional: true, always_run: false so we can run it with /test until origin tests are for the job are working as expected

Depends-on:

Origin PR with the tests

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2024
@openshift-ci-robot
Copy link
Contributor

@qinqon, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto master: %!w(<nil>)
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@maiqueb @qinqon
ovn-kubernetes, virt: add new AWS virt lane to run OVN presubmits
256a074 
Signed-off-by: Miguel Duarte Barroso <[email protected]>
@maiqueb @qinqon
udn, virt: enable primary UDN binding
2242b61 
This HCO feature gate was introduced in [0]; it also requires the
KubeVirt IPAM controller component to persist the IP addresses between
VM migrations, and restarts.

[0] - kubevirt/hyperconverged-cluster-operator#3034

Signed-off-by: Miguel Duarte Barroso <[email protected]>
@maiqueb @qinqon
udn, virt, tests: run only virt-aware tests
3e1ba76 
A future PR will add tests for this feature gate and feature in
openshift/origin project.

Signed-off-by: Miguel Duarte Barroso <[email protected]>
@maiqueb @qinqon
ovn-kubernetes, virt: add new AWS virt lane to run OVN 4.18/4.19 pres…
03a695a 
…ubmits

Signed-off-by: Miguel Duarte Barroso <[email protected]>
@qinqon qinqon force-pushed the virt-tech-preview-lane-on-presubmits-2 branch from 2ceb2d9 to d58b7ec Compare October 17, 2024 17:17
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2024
@qinqon
Copy link
Contributor Author

qinqon commented Oct 17, 2024

/pj-rehearse pull-ci-openshift-origin-master-e2e-aws-ovn-virt-techpreview

@openshift-ci-robot
Copy link
Contributor

@qinqon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jluhrsen
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jluhrsen, qinqon
Once this PR has been reviewed and has the lgtm label, please assign danwinship, stbenjam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qinqon qinqon mentioned this pull request Oct 18, 2024
Open
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

@qinqon: This PR was included in a payload test run from openshift/origin#29199
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@qinqon
Copy link
Contributor Author

qinqon commented Oct 18, 2024

/payload-job-with-prs pull-ci-openshift-origin-master-e2e-aws-ovn-virt-techpreview openshift/origin#29199

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

@qinqon: the repo openshift/release does not contribute to the OpenShift official images

@qinqon qinqon force-pushed the virt-tech-preview-lane-on-presubmits-2 branch from d58b7ec to 691ca5e Compare October 18, 2024 07:50
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2024
@qinqon qinqon changed the title Virt tech preview lane on presubmits 2 ovn-k: add presubmit for virt Oct 18, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@qinqon: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-origin-master-e2e-aws-ovn-virt-techpreview openshift/origin presubmit Presubmit changed
pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-virt-techpreview openshift/ovn-kubernetes presubmit Presubmit changed
pull-ci-openshift-ovn-kubernetes-release-4.18-e2e-aws-ovn-virt-techpreview openshift/ovn-kubernetes presubmit Presubmit changed
pull-ci-openshift-ovn-kubernetes-release-4.19-e2e-aws-ovn-virt-techpreview openshift/ovn-kubernetes presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

@qinqon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/origin/master/e2e-aws-ovn-virt-techpreview d58b7ec link unknown /pj-rehearse pull-ci-openshift-origin-master-e2e-aws-ovn-virt-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-gemoli danilo-gemoli Awaiting requested review from danilo-gemoli

@danwinship danwinship Awaiting requested review from danwinship

Assignees

@jluhrsen jluhrsen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qinqon @openshift-ci-robot @jluhrsen @openshift-merge-robot @maiqueb