Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Examples to Use c++14 #3931

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Update Examples to Use c++14 #3931

merged 2 commits into from
Oct 9, 2024

Conversation

alexbeattie42
Copy link

@alexbeattie42 alexbeattie42 commented Oct 4, 2024

Fixes issue #3929

Brief summary of changes

Update CMakeLists.txt files to use c++14

Testing I've completed

Built examples independently (from an open-sim core installation) and everything compiles and runs.

Looking for feedback on...

None

CHANGELOG.md (choose one)

  • updated.

This change is Reviewable

@alexbeattie42
Copy link
Author

Updated comments for c++14

Copy link
Member

@nickbianco nickbianco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment about the changelog. I also enabled the CI to make sure that upgrading Tropter to C++14 has no downstream effect on Moco.

CHANGELOG.md Outdated Show resolved Hide resolved
@aymanhab
Copy link
Member

aymanhab commented Oct 9, 2024

One follow up question related to this change. Would it be a problem for dependencies if they were built with C++11 flags/settings (e.g. Simbody, and the third party dependencies for Moco) Just wanted to know if this has been assessed. @adamkewley may have performed this assessment since he's been on the forefront of upgrades in the osimCreator project.

@adamkewley
Copy link
Contributor

One follow up question related to this change. Would it be a problem for dependencies if they were built with C++11 flags/settings (e.g. Simbody, and the third party dependencies for Moco) Just wanted to know if this has been assessed. @adamkewley may have performed this assessment since he's been on the forefront of upgrades in the osimCreator project.

It's completely fine. Recommended, even, in the case where the code doesn't need a higher level. OSC's compiling with C++20, OpenSim is C++14, and simbody is C++11. The other dependencies are whatever they are. Haven't had any issues with it via clang, gcc, or MSVC on Linux/Mac/Windows, with/without libASAN, debugging, etc. etc.

@aymanhab
Copy link
Member

aymanhab commented Oct 9, 2024

Awesome, thanks much @adamkewley 👍

@nickbianco
Copy link
Member

Per @adamkewley's comment, let's merge. Thanks @alexbeattie42!

@nickbianco nickbianco merged commit 33dbcd2 into opensim-org:main Oct 9, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants