-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Examples to Use c++14 #3931
Conversation
Updated comments for c++14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment about the changelog. I also enabled the CI to make sure that upgrading Tropter to C++14 has no downstream effect on Moco.
One follow up question related to this change. Would it be a problem for dependencies if they were built with C++11 flags/settings (e.g. Simbody, and the third party dependencies for Moco) Just wanted to know if this has been assessed. @adamkewley may have performed this assessment since he's been on the forefront of upgrades in the osimCreator project. |
It's completely fine. Recommended, even, in the case where the code doesn't need a higher level. OSC's compiling with C++20, OpenSim is C++14, and simbody is C++11. The other dependencies are whatever they are. Haven't had any issues with it via clang, gcc, or MSVC on Linux/Mac/Windows, with/without libASAN, debugging, etc. etc. |
Awesome, thanks much @adamkewley 👍 |
Per @adamkewley's comment, let's merge. Thanks @alexbeattie42! |
Fixes issue #3929
Brief summary of changes
Update
CMakeLists.txt
files to use c++14Testing I've completed
Built examples independently (from an open-sim core installation) and everything compiles and runs.
Looking for feedback on...
None
CHANGELOG.md (choose one)
This change is