Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update setting PATH env for Linux build script #3932

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update setting PATH env for Linux build script #3932

wants to merge 2 commits into from

Conversation

alexbeattie42
Copy link

@alexbeattie42 alexbeattie42 commented Oct 4, 2024 •
edited by aymanhab
Loading

Fixes issue #3928

Brief summary of changes

Check which shell the user is using and attempt to update path if the shell is bash.

Testing I've completed

Ran the build script multiple times to ensure that .bashrc is updated if variable exists and created if it doesn't.

Looking for feedback on...

  • Is is suitable to assume the system will have grep, and sed available?

CHANGELOG.md (choose one)

  • no need to update because the change only affects a build script

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alexbeattie42