Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid publishing joint messages with duplicate stamps #115

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

MarkHedleyJones
Copy link
Contributor

This pull request prevents the ypspur ros node from publishing joint state messages with duplicate timestamps.

@at-wat
Copy link
Member

at-wat commented Jan 9, 2024

[86] PASSED on noetic

All tests passed
build/test_results/ypspur_ros/roslint-ypspur_ros.xml: 1 tests
build/test_results/ypspur_ros/rostest-test_test_joint_trajectory.xml: 1 tests
build/test_results/ypspur_ros/rosunit-test_joint_trajectory.xml: 2 tests
Summary: 4 tests, 0 errors, 0 failures, 0 skipped

@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (32a36c1) 23.91% compared to head (23d20f8) 23.95%.

Files Patch % Lines
src/ypspur_ros.cpp 25.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   23.91%   23.95%   +0.04%     
==========================================
  Files           3        3              
  Lines         690      693       +3     
==========================================
+ Hits          165      166       +1     
- Misses        525      527       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@at-wat at-wat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@at-wat at-wat merged commit 0e63887 into openspur:master Jan 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants