Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to wait convergence of joint trajectory angle and velocity #122

Merged

Conversation

Taka-Kazu
Copy link
Contributor

@Taka-Kazu Taka-Kazu commented Mar 27, 2024

When controlling in joint trajectory mode, sometimes the joint's angle and velocity don't converge in the specified range after the duration (time_from_start). If the joint overshoots the target position in the trajectory, the joint rotates backward, but in some use cases, this behavior is not desirable.

By this PR, wait_convergence_of_joint_trajectory_angle_vel_ parameter is added. If this parameter is false, the control mode transitions to velocity mode without checking the convergence after the duration of time_from_start. If the parameter is true, the behavior is the same as before.

@at-wat
Copy link
Member

at-wat commented Mar 27, 2024

[104] PASSED on noetic

All tests passed
build/test_results/ypspur_ros/roslint-ypspur_ros.xml: 1 tests
build/test_results/ypspur_ros/rostest-test_test_joint_trajectory.xml: 1 tests
build/test_results/ypspur_ros/rosunit-test_joint_trajectory.xml: 2 tests
Summary: 4 tests, 0 errors, 0 failures, 0 skipped

@Taka-Kazu Taka-Kazu marked this pull request as ready for review March 28, 2024 01:16
@Taka-Kazu Taka-Kazu requested a review from at-wat March 28, 2024 01:16
Copy link
Member

@at-wat at-wat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@at-wat at-wat merged commit 97d8a8b into master Mar 28, 2024
3 checks passed
@at-wat at-wat deleted the add-option-to-wait-convergence-of-joint-trajectory-angle-vel branch March 28, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants