Rewrite jinja2 snippet to determine if juju snap should be classic #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit 16b1561 introduced a dynamic evaluation to set the `classic` property to true/false when installing the juju snap, although that line produces a "False" which Ansible is evaluating to true. This change takes a different approach dropping the use of an inline-if which was producing a string value, now it's being used a conditional expression to force the evaluation as a boolean.
ajkavanagh
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit 16b1561 introduced a dynamic evaluation to set the
classicproperty to true/false when installing the juju snap, although that line produces a "False" which Ansible is evaluating to true.This change takes a different approach dropping the use of an inline-if which was producing a string value, now it's being used a conditional expression to force the evaluation as a boolean.