Feature: NYT Book list screen #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redone DI
Add automatic retry on connection recovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pagination was implemented using Jetpack Paging3 due to the fact that NYT book list APIs support pagination via offset query parameter.
Cache was implemented using Room and as part of Paging3 using a RemoteMediator (BookListRemoteMediator). This implies that the application is still usable even without Internet connection.
The application automatically retries a failed load due to lack of internet once it gets online. (InternetConnectionMonitor)
Unit tests were written for BookListMediator as Intrumented test because a memory SQLite database was needed. We could have done Fake DAOs, but this would have introduced boilerplate and more untested code.
Multiple screen support was implemented using Window Size classes breakpoints (see: https://developer.android.com/develop/ui/compose/layouts/adaptive/window-size-classes).
Elements in the list are slightly bigger in Medium width screens and laid out as a Grid in Expanded width screens.
This feature was designed with scalability and mantainability in mind. It can be noticed that BookListFragment accepts parameters for loading any list from NYT API. However it will always load the Hardcover Fiction list since list name fetching is not supported.
Techstack:
Testing techstack:
Screenshots:
