Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Adding, Changing, or Removing a Feature
subtensor migrated to version that handles certificate discovery
Description of the Change
Adds the ability to send neuron certificate and receive other neuron's certificates. This change will enable setting up mutual tls between neurons
serve_axon
function takes an additional optional parameter certificateif certificate is present the
serve_axon_tls
rpc call will be called on the subtensor and the neuron's certificate will be discoverable through the subtensor. The function will behave the same other than the possible storing of certificate.get_neuron_certificate(netuid, neuron_uid)
will fetch from the subtensor a specific neuron's certificate.Alternate Designs
save the certificate as a field in the axon.
This can be implemented either:
serve_axon
,get_neuron_info
and other function. However this would break compatibility for multiple rpc calls encoding and would need patching.Possible Drawbacks
none?
Verification Process
TODO
Release Notes
serve_axon
function and fetched via theget_neuron_certificate
function