fix regression where COLD_PW can no longer be passed with env vars co… #2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Child Hotkeys netuid Refactor
…-and-assertions Applies metagraph fix and assertions
…tensor-reconnection-logic Add reconnection logic + tests
…pentensor#2287) * removed exit sys call for ConnectionRefusedError in _get_substrate * removed unnecessary sys import * ruff format fix
…7.4.0 Backmerge/release 7.4.0
ppolewicz
reviewed
Sep 14, 2024
| } | ||
|
|
||
| monkeypatch.setenv("bt_cold_pw_wallet", password_by_wallet["WALLET"]) | ||
| monkeypatch.setenv("BT_COLD_PW_My_Wallet", password_by_wallet["my_wallet"]) | ||
| monkeypatch.setenv("BT_COLD_PW_My-Wallet3", password_by_wallet["my-wallet3"]) |
There was a problem hiding this comment.
won't the new warning crash this?
There was a problem hiding this comment.
CI is passing. Test are not run with pytest -W error if this is what you are referring to.
Or did I misunderstand you and you mean something else?
Co-authored-by: garrett-opentensor <[email protected]>
alex-drocks
approved these changes
Sep 17, 2024
ibraheem-opentensor
force-pushed
the
staging
branch
from
f13f5f3
to
73d9fd4
Compare
|
no longer relevant after refactor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Description of the Change
Apparently, in the context of python it was possible to set a env var with hyphen in it. Which makes change introduced by #1949 a breaking one which is not acceptable as it was introduced in minor version of bittensor, hence breaking semver contract.
This PR makes sure we support proper env variable names, while also not breaking users that used hyphens within the env var name.
See https://discord.com/channels/1120750674595024897/1242999357436071956/1284309400751964271 for more context.
Alternate Designs
Ignore the regression, but that conflicts with semver versioning and further discourages keeping with the latest bittensor version.
Possible Drawbacks
Not forcing users to migrate asap.
Verification Process
Unit test
Release Notes
BT_COLD_PW_My-Wallet3=pw. Please note this form is deprecated, and one should useBT_COLD_PW_My_Wallet3=pwinstead.