-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/hotkey swap #556
Merged
Merged
Refactor/hotkey swap #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distributedstatemachine
requested review from
sam0x17,
JohnReedV,
a team,
keithtensor and
open-junius
June 21, 2024 16:49
sam0x17
previously approved these changes
Jun 21, 2024
open-junius
reviewed
Jun 21, 2024
sam0x17
approved these changes
Jun 21, 2024
open-junius
approved these changes
Jun 21, 2024
JohnReedV
reviewed
Jun 21, 2024
JohnReedV
approved these changes
Jun 21, 2024
sam0x17
added
devnet-ready
PR's companion has been merged into devnet-ready
on-devnet
PR has been deployed to devnet
and removed
devnet-ready
PR's companion has been merged into devnet-ready
labels
Jun 24, 2024
distributedstatemachine
added
devnet-pass
PR has been tested on devnet
on-testnet
PR has been deployed to testnet
testnet-pass
PR was successfully tested on testnet
and removed
on-devnet
PR has been deployed to devnet
labels
Jun 25, 2024
Co-authored-by: Keith <[email protected]>
Co-authored-by: orriin <[email protected]>
distributedstatemachine
force-pushed
the
refactor/hotkey_swap
branch
from
July 2, 2024 19:46
3b1d766
to
2dda611
Compare
distributedstatemachine
added
testnet-pass
PR was successfully tested on testnet
and removed
testnet-pass
PR was successfully tested on testnet
on-testnet
PR has been deployed to testnet
labels
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devnet companion: #567
Description
This PR :
refactors the hot key swap function to make it more testable
adds unit tests
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmt
andcargo clippy
to ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.