-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/cold key swap #611
Merged
Merged
Feat/cold key swap #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distributedstatemachine
requested review from
keithtensor,
open-junius and
orriin
July 4, 2024 10:37
keithtensor
reviewed
Jul 4, 2024
keithtensor
reviewed
Jul 4, 2024
open-junius
reviewed
Jul 4, 2024
open-junius
reviewed
Jul 4, 2024
open-junius
reviewed
Jul 4, 2024
orriin
reviewed
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed about half, will check the rest in approximately 1 hour
keithtensor
reviewed
Jul 4, 2024
keithtensor
reviewed
Jul 4, 2024
orriin
reviewed
Jul 4, 2024
orriin
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after existing comments are addressed
keithtensor
approved these changes
Jul 4, 2024
distributedstatemachine
force-pushed
the
feat/cold_key_swap
branch
from
July 4, 2024 15:06
169d616
to
0855df7
Compare
camfairchild
reviewed
Jul 4, 2024
Co-authored-by: Cameron Fairchild <[email protected]>
Co-authored-by: Cameron Fairchild <[email protected]>
Co-authored-by: Cameron Fairchild <[email protected]>
Co-authored-by: Cameron Fairchild <[email protected]>
camfairchild
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an extrinsic to do a cold key swap
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmt
andcargo clippy
to ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.