Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with Subtensor storage versions #644

Merged
merged 5 commits into from
Jul 16, 2024

Conversation

distributedstatemachine
Copy link
Collaborator

Description

This PR Subtensor storage version. We had it hardcoded to 6, but the on chain version was 7, which was causing issue with try runtime and running the actual migrations on clone.

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

unconst
unconst previously approved these changes Jul 16, 2024
sam0x17
sam0x17 previously approved these changes Jul 16, 2024
pallets/subtensor/src/lib.rs Outdated Show resolved Hide resolved
@sam0x17 sam0x17 requested a review from a team July 16, 2024 20:05
@distributedstatemachine distributedstatemachine merged commit 5adbbd9 into main Jul 16, 2024
12 of 13 checks passed
@camfairchild camfairchild deleted the hotfix/storage_version_inconsistency branch July 18, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants