Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/devnet companion/check metadata hash extension #649

Merged

Conversation

camfairchild
Copy link
Contributor

Description

Devnet Companion for #637

Upgrades to polkadot-sdk v1.10.0-rc2 v1.10.0-rc3 which supports frame_metadata_hash_extension::CheckMetadataHash, required for Zondax's generic-substrate Ledger app.

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe): requires new build flags for production (to generate metadata hash for wasm)

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional Notes

TODO:

  • Test integration with PolkadotJS, other wallets, etc.

@camfairchild
Copy link
Contributor Author

replaces #642

@camfairchild camfairchild requested review from sam0x17 and distributedstatemachine and removed request for sam0x17 July 19, 2024 13:14
@sam0x17
Copy link
Contributor

sam0x17 commented Jul 19, 2024

looks good, E2E on the fritz again of course

@camfairchild
Copy link
Contributor Author

looks good, E2E on the fritz again of course

Might also be this issue: opentensor/bittensor#2156
This change adds an extra Mode bit to the extrinsic which breaks client compatibility.

@camfairchild camfairchild merged commit 1c50295 into devnet-ready Jul 22, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants