Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean hot swap #658

Closed
wants to merge 72 commits into from
Closed

Clean hot swap #658

wants to merge 72 commits into from

Conversation

unconst
Copy link
Contributor

@unconst unconst commented Jul 22, 2024

Description

Clean up hotkey swap with new tests.

keithtensor and others added 30 commits June 13, 2024 23:29
(Devnet Ready) Ban unsafe arithmetic operations
[devnet companion] prevent accidental changes to storage structs
[devnet-companion] prevent accidental changes to storage structs (2)
…ne-devnet-companion

[devnet-companion] Fix Senate membership changes
…-ready

Override default pages to fix archive sync [devnet-ready]
…alpha_2

Devnet companion feat/liquid alpha 2
sam0x17 and others added 23 commits June 25, 2024 02:05
…key_swap

[devnet companion]refactor/hotkey swap
…7-12-2024

merge main into devnet-ready 7-12-2024
* draft: hotkey swap for senate

* feat: remove schedule coldkey swap

* chore: fix tests

* fixes for network resumption

* chore: bump spec

* fix: add back arbitration check

* fix: hotkey

* fix: coldkey arb swap hotkey

* swap delegate stake also

* add test for this

* swap over stakinghotkeys map

* check map first

* add staking hotkeys test

* no take

* keep old stake

* add check to test

* fix some tests

* fix delegate test

* update staking hotekys maps

* init

* comment out

* add admin swap

* fix swap

* ..

* hotkey staking maps fix

* remove staking hotkeys

* remove commented code

* cargo fmt

* cargo fix --workspace

* bump spec_version to 165

* swap hotkey benchmark removed

* add migration and tests for total coldkey hotfix

* adds new test for missing hotkey value

* bump migration values

* fmt

* feat: try runtime passing

* chore: remove commented code

* chore: make logs human readable

* chore: remove comments

* Update pallets/subtensor/src/lib.rs

Co-authored-by: Sam Johnson <[email protected]>

* add test first

* clear map before rest of migration

* track weight for clear/removal

* add comment

* rename test

* add test for emission appends staking hotkeys map

* Update runtime/src/lib.rs

---------

Co-authored-by: Samuel Dare <[email protected]>
Co-authored-by: distributedstatemachine <[email protected]>
Co-authored-by: const <[email protected]>
Co-authored-by: Sam Johnson <[email protected]>
Co-authored-by: Unconst <[email protected]>
[devnet-companion] Make weighted_median iterative
* draft: hotkey swap for senate

* feature-gate hash

* use 1.10.0-rc2

* add feature

* feat: remove schedule coldkey swap

* chore: fix tests

* fixes for network resumption

* chore: bump spec

* fix: add back arbitration check

* fix: hotkey

* fix: coldkey arb swap hotkey

* swap delegate stake also

* add test for this

* swap over stakinghotkeys map

* check map first

* add staking hotkeys test

* no take

* keep old stake

* add check to test

* fix some tests

* fix delegate test

* update staking hotekys maps

* init

* comment out

* add admin swap

* fix swap

* ..

* hotkey staking maps fix

* remove staking hotkeys

* remove commented code

* cargo fmt

* cargo fix --workspace

* bump spec_version to 165

* swap hotkey benchmark removed

* add migration and tests for total coldkey hotfix

* adds new test for missing hotkey value

* bump migration values

* fmt

* lock file update

* add production just target

* fmt

* clippy

* benchmarking fix

* feat: try runtime passing

* chore: remove commented code

* chore: make logs human readable

* chore: remove comments

* Update pallets/subtensor/src/lib.rs

Co-authored-by: Sam Johnson <[email protected]>

* fmt

* use rc3 with new fix polkadot-sdk/pull/4117

* incl lock

* bump CI

---------

Co-authored-by: Samuel Dare <[email protected]>
Co-authored-by: distributedstatemachine <[email protected]>
Co-authored-by: const <[email protected]>
Co-authored-by: Sam Johnson <[email protected]>
Co-authored-by: Unconst <[email protected]>
@unconst unconst added the devnet-ready PR's companion has been merged into devnet-ready label Jul 22, 2024
@unconst unconst changed the base branch from main to devnet July 22, 2024 20:22
@unconst unconst changed the base branch from devnet to main July 22, 2024 20:23
@unconst unconst closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devnet-ready PR's companion has been merged into devnet-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants