Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neuron pruning based on registration date of UID #726

Merged
merged 22 commits into from
Aug 13, 2024

Conversation

VectorChat
Copy link
Contributor

@VectorChat VectorChat commented Aug 8, 2024

Description

This introduces a change to how the current get_neuron_to_prune function works. For ties with the lowest pruning score, the neuron that was registered oldest is chosen instead. If all neurons are immune, the same rules apply.

  • includes a test function test_burn_registration_pruning_scenarios for testing out different scenarios.
  • includes new utility function get_neuron_is_immune

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

There are not any breaking changes to my knowledge.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@VectorChat VectorChat marked this pull request as ready for review August 8, 2024 22:13
@JohnReedV
Copy link
Contributor

Hello and thank you for your contribution!

It looks like the CI is failing due to some linting issues. Could you please address these by running
cargo clippy --workspace --all-targets --all-features -- -D warnings and making the necessary changes?

@VectorChat
Copy link
Contributor Author

Alright, linting issues should be resolved now.

JohnReedV
JohnReedV previously approved these changes Aug 13, 2024
@JohnReedV JohnReedV requested a review from a team August 13, 2024 00:38
@sam0x17 sam0x17 changed the base branch from main to devnet-ready August 13, 2024 04:05
@sam0x17 sam0x17 dismissed JohnReedV’s stale review August 13, 2024 04:05

The base branch was changed.

@sam0x17 sam0x17 merged commit 5b2dde6 into opentensor:devnet-ready Aug 13, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Neuron pruning from the subnets is unfair and always favors low UID numbers.
8 participants