-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neuron pruning based on registration date of UID #726
Merged
sam0x17
merged 22 commits into
opentensor:devnet-ready
from
VectorChat:feat/neuron-pruning-change
Aug 13, 2024
Merged
Neuron pruning based on registration date of UID #726
sam0x17
merged 22 commits into
opentensor:devnet-ready
from
VectorChat:feat/neuron-pruning-change
Aug 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per this Discord thread: https://discord.com/channels/799672011265015819/1260678915186495509 Docs issue: opentensor/developer-docs#221
Removing from the "main" branch the doc to run subtensor locally
…-1-1 Update README.md
Only run spec version check when the skip label doesn't exist
…ch-clippy fix clippy
Bump `main` spec version
Hello and thank you for your contribution! It looks like the CI is failing due to some linting issues. Could you please address these by running |
Alright, linting issues should be resolved now. |
JohnReedV
previously approved these changes
Aug 13, 2024
sam0x17
approved these changes
Aug 13, 2024
JohnReedV
approved these changes
Aug 13, 2024
This was referenced Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces a change to how the current
get_neuron_to_prune
function works. For ties with the lowest pruning score, the neuron that was registered oldest is chosen instead. If all neurons are immune, the same rules apply.test_burn_registration_pruning_scenarios
for testing out different scenarios.get_neuron_is_immune
Related Issue(s)
Type of Change
Breaking Change
There are not any breaking changes to my knowledge.
Checklist
cargo fmt
andcargo clippy
to ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.