Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken workspace root package #744

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Conversation

sam0x17
Copy link
Contributor

@sam0x17 sam0x17 commented Aug 19, 2024

Some recent changes to the workspace root package broke some syntax like cargo test --features=try-runtime without --workspace. This fixes some issues in the root workspace Cargo.toml re-enabling that old behavior (both node and runtime are now default build targets for workspace root package) and fixing some other issues with the workspace setup

@sam0x17 sam0x17 requested a review from unconst as a code owner August 19, 2024 23:44
@sam0x17 sam0x17 changed the base branch from main to devnet-ready August 19, 2024 23:44
@sam0x17 sam0x17 self-assigned this Aug 19, 2024
@sam0x17 sam0x17 added the no-spec-version-bump PR does not contain changes that requires bumping the spec version label Aug 21, 2024
@unconst unconst merged commit 3496c34 into devnet-ready Aug 23, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-spec-version-bump PR does not contain changes that requires bumping the spec version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants