Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker, merge conflicts and publish docker images on tag #768

Merged
merged 9 commits into from
Aug 28, 2024

Conversation

distributedstatemachine
Copy link
Collaborator

Description

Fixes devnet merge conflict

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@distributedstatemachine distributedstatemachine changed the title Chore/devnet merge conflic Chore/devnet merge conflict Aug 28, 2024
@distributedstatemachine distributedstatemachine changed the base branch from main to devnet-ready August 28, 2024 14:22
@distributedstatemachine distributedstatemachine changed the title Chore/devnet merge conflict Fix docker, merge conflicts and publish docker images on tag Aug 28, 2024
@unconst unconst merged commit 12140e4 into devnet-ready Aug 28, 2024
11 checks passed
@distributedstatemachine distributedstatemachine deleted the chore/devnet_merge_conflic branch September 1, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants