Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit reveal 2 Improvements #893

Merged
merged 15 commits into from
Oct 31, 2024
Merged

Commit reveal 2 Improvements #893

merged 15 commits into from
Oct 31, 2024

Conversation

JohnReedV
Copy link
Contributor

@JohnReedV JohnReedV commented Oct 30, 2024 •
edited
Loading

Description

  • Used the set_weights rate limit in commit_weights
  • Added first and last reveal blocks to WeightCommits storage item.
  • Reverted the new hyperparameter's name to the old.
  • Made order enforcement during batch_reveals more lenient.
  • Added commit-reveal related events

@JohnReedV JohnReedV changed the title Commit reveal 2 1 Commit reveal 2 Improvements Oct 30, 2024
@JohnReedV JohnReedV marked this pull request as ready for review October 30, 2024 22:21
@JohnReedV
use new index
8a97a12 
previously deployed to testnet with a different name for that index
@JohnReedV JohnReedV requested a review from a team October 30, 2024 22:39
sam0x17
sam0x17 previously approved these changes Oct 31, 2024
View reviewed changes
@sam0x17 sam0x17 added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Oct 31, 2024
sam0x17
sam0x17 previously approved these changes Oct 31, 2024
View reviewed changes
@unconst unconst merged commit f3b76d8 into devnet-ready Oct 31, 2024
45 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unconst unconst unconst approved these changes

@sam0x17 sam0x17 sam0x17 approved these changes

Assignees
No one assigned
Labels
skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnReedV @sam0x17 @unconst