Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add key swaps & set_children to proxies #912

Merged
merged 6 commits into from
Nov 12, 2024
Merged

Add key swaps & set_children to proxies #912

merged 6 commits into from
Nov 12, 2024

Conversation

JohnReedV
Copy link
Contributor

@JohnReedV JohnReedV commented Nov 4, 2024 •
edited
Loading

Description

Adds

  • schedule_swap_coldkey and swap_hotkey to the NonFungibile proxy type
  • ChildKeys ProxyType
  • set_children & set_childkey_take to the ChildKeys ProxyType.

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

@JohnReedV JohnReedV marked this pull request as ready for review November 4, 2024 21:56
@JohnReedV JohnReedV requested a review from a team November 4, 2024 23:09
camfairchild
camfairchild previously approved these changes Nov 5, 2024
View reviewed changes
@JohnReedV JohnReedV requested a review from a team November 5, 2024 22:16
@sam0x17 sam0x17 merged commit 82664af into devnet-ready Nov 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camfairchild camfairchild camfairchild approved these changes

@sam0x17 sam0x17 sam0x17 approved these changes

@unconst unconst Awaiting requested review from unconst unconst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnReedV @sam0x17 @camfairchild