Lint ForbidKeysRemoveCall

[eagr]

Description

Add a custom lint to forbid Keys::<T>::remove()

Related Issue(s)

• Closes Check in static analysis for removals from Keys map #915

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Other (please describe): lint

[eagr]

first, let's see if the lint complains about the usage in replace_neuron, then I'll disable the lint in it

[sam0x17]

looks like this one is failing @eagr: https://github.com/opentensor/subtensor/actions/runs/11709455612/job/32816680567?pr=927

[eagr]

yeah as expected, kinda wanted to watch it fail first. I'll disable the lint on that line then it should pass

[eagr]

I think #[allow(unknown_lints)] is meant for situations like this (to prevent the compiler from failing when using custom lints) right?

[sam0x17]

looks good to me except I would prefer in the tests you use quote! directly so we don't have to do any string parsing. Makes the tests a little bit faster. See the tests for the other lints I did for inspiration! @eagr

[eagr]

done