Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bot warning when posting a hotfix PR #953

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Conversation

sam0x17
Copy link
Contributor

@sam0x17 sam0x17 commented Nov 10, 2024

Warning looks like this:

🚨🚨🚨 HOTFIX DETECTED 🚨🚨🚨

It looks like you are trying to merge a hotfix PR into main. If this isn't what you wanted to do, and you just wanted to make a regular PR, please close this PR, base your changes off the devnet-ready branch and open a new PR into devnet ready.

If you are trying to merge a hotfix PR, please complete the following essential steps:

  1. go ahead and get this PR into main merged, so we can get the change in as quickly as possible!
  2. merge main into testnet, bumping spec_version
  3. deploy testnet
  4. merge testnet into devnet, bumping spec_version
  5. deploy devnet
  6. merge devnet into devnet-ready

If you do not complete these steps, your hotfix may be inadvertently removed in the future when branches are promoted to `main`, so it is essential that you do so.

@sam0x17 sam0x17 self-assigned this Nov 10, 2024
@sam0x17 sam0x17 added the blue team defensive programming, CI, etc label Nov 10, 2024
@sam0x17 sam0x17 changed the base branch from main to devnet-ready November 10, 2024 07:24
@sam0x17 sam0x17 requested review from gztensor and a team November 10, 2024 07:28
@sam0x17 sam0x17 added the no-spec-version-bump PR does not contain changes that requires bumping the spec version label Nov 10, 2024
@sam0x17 sam0x17 changed the base branch from devnet-ready to main November 12, 2024 17:56
@sam0x17 sam0x17 changed the base branch from main to devnet-ready November 12, 2024 17:57
@sam0x17 sam0x17 merged commit db3bd8a into devnet-ready Nov 12, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blue team defensive programming, CI, etc no-spec-version-bump PR does not contain changes that requires bumping the spec version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants