-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix print_exception function call #146
base: staging
Are you sure you want to change the base?
Conversation
Note: not sure why the |
Edit: Nevermind. My bad |
The
print_exception
was throwing an exception since we were defining a named parameter out of order. I might be wrong in this one but afaik, when we are using named parameters, we need to respect their order, meaning that if we define the second named parameter of a function, the first one needs to be declared if it doesn't have a default value.In this case, the function signature of
print_exception
is:Since we were defining the
value
parameter explicitly, we must defineetype
param as well.The fix bellow defines the
etype
,value
andtb
implicitly so this LOC doesn't throw more exceptions.Closes issue #145