Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix print_exception function call #146

Open
wants to merge 6 commits into
base: staging
Choose a base branch
from

Conversation

p-ferreira
Copy link
Contributor

The print_exception was throwing an exception since we were defining a named parameter out of order. I might be wrong in this one but afaik, when we are using named parameters, we need to respect their order, meaning that if we define the second named parameter of a function, the first one needs to be declared if it doesn't have a default value.

In this case, the function signature of print_exception is:

def print_exception(etype, value, tb, limit=None, file=None, chain=True):

Since we were defining the value parameter explicitly, we must define etype param as well.

The fix bellow defines the etype, value and tb implicitly so this LOC doesn't throw more exceptions.

Closes issue #145

@p-ferreira p-ferreira linked an issue Aug 30, 2023 that may be closed by this pull request
@p-ferreira p-ferreira changed the base branch from main to staging August 30, 2023 18:46
@p-ferreira
Copy link
Contributor Author

Note: not sure why the requirements.txt is being shown as modified since those changes are already implemented in staging. Disregard that, probably a github bug

@camfairchild
Copy link
Contributor

camfairchild commented Aug 30, 2023

Note: not sure why the requirements.txt is being shown as modified since those changes are already implemented in staging. Disregard that, probably a github bug

Staging doesn't show it in the file. I'll check on the blame

Edit: Nevermind. My bad
Maybe rebase/merge staging

@p-ferreira p-ferreira added the 1.2.1 Potential push for v1.2.1 label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.2.1 Potential push for v1.2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

print_exception error on run.py catch clause
3 participants