Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[radio] add multipurpose frame support #943

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhanglongxia
Copy link
Contributor

No description provided.

@zhanglongxia zhanglongxia added the enhancement New feature or request label Nov 25, 2024
@zhanglongxia zhanglongxia requested review from edmont and jwhui November 25, 2024 15:35
@LuDuda
Copy link
Member

LuDuda commented Nov 29, 2024

Hello @zhanglongxia,

Thank you for this contribution. Please note that this repository is based on our nRF5 SDK which is currently in maintenance mode. We do develop new features on top of nRF Connect SDK. I'm fine to integrate it here, however, please note that many new enhancements e.g. with CSL are part of the Radio Driver included in NCS. Do you want to use this repository for testing/production?

FYI: @ankuns

@zhanglongxia
Copy link
Contributor Author

Hello @zhanglongxia,

Thank you for this contribution. Please note that this repository is based on our nRF5 SDK which is currently in maintenance mode. We do develop new features on top of nRF Connect SDK. I'm fine to integrate it here, however, please note that many new enhancements e.g. with CSL are part of the Radio Driver included in NCS. Do you want to use this repository for testing/production?

FYI: @ankuns

Hi LuDuda, I saw that the nrfconnect doesn't support the multipurpose frame now. I submitted this commit for verifying and testing the wakeup feature on nrf52840DK dev board. As you mentioned, the nRF5 SDK is in maintenance mode, does Nordic have a plan to migrate the radio driver related code from the nRF5 SDK to nRF Connect SDK?

@LuDuda
Copy link
Member

LuDuda commented Dec 2, 2024

Thank you so much! Indeed full support for filtering multipurpose frames are not implemented there, though there is a bypass mechanism for now which allows for testing. Yes, we do plan to have multipurpose filtering support as well.

Let me ask @ankuns to review the PR here - which we could merge here as well and might be a good solution for NCS as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants