Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dispatcher.go] Change log style of push status and unnecessary break - Part 1 of RTEA #357

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

Vinggui
Copy link
Contributor

@Vinggui Vinggui commented Sep 11, 2022

Contribution description

This PR is part of the process of breaking PR #235 in small steps, a process nominated "Road to Energy Analysis" (RTEA). These small modifications will lead to the whole improvement started on March 2022. At the end of these steps, OT-NS will be capable of precisely estimating energy consumption, collision events (channel aware), and plot all the data in real-time as the simulation progress.

At the moment, OT-NS can not estimate energy, collisions, nor transmission energy. Also, even though OT is working well in simulation, many of its recovery properties are not correctly simulated as they would happen in real devices due to its incorrect timing events at the simulated radio part.

Main modifications

This PR improved the readability of log messages when status push events happens in the simulator.
Another cosmetic modification is the removal of unnecessary breaks. It addresses only the following files:

  • /dispatcher/dispatcher.go

Roadmap

This is part 1 of the RTEA (Road to Energy Analysis) steps to PR #235 and PR #7500.

Part 1: This PR;
Part 2: PR #8144;
Part 3: PR #359;
Part 4: PR #8152;
Part 5: PR #362;
Part 6: PR #8165;
Part 7: PR #363;
Part 8: PR #8173;
Part 9: PR #365;
Part 10: PR #366;
Part 11: PR #367.

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2022

Codecov Report

Merging #357 (c73d897) into main (c616148) will decrease coverage by 0.06%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
- Coverage   49.97%   49.91%   -0.07%     
==========================================
  Files          38       38              
  Lines        4608     4602       -6     
==========================================
- Hits         2303     2297       -6     
  Misses       2123     2123              
  Partials      182      182              
Impacted Files Coverage Δ
web/site/bindata.go 99.00% <ø> (-0.01%) ⬇️
dispatcher/dispatcher.go 56.97% <50.00%> (-0.13%) ⬇️
otnstester/OtnsTest.go 89.44% <100.00%> (ø)

@Vinggui Vinggui changed the title style: change log style of push status [dispatcher.go] change log style of push status and unnecessary break Sep 12, 2022
@Vinggui Vinggui changed the title [dispatcher.go] change log style of push status and unnecessary break [dispatcher.go] Style: change log style of push status and unnecessary break - Part 1 of RTEE Sep 13, 2022
@Vinggui Vinggui changed the title [dispatcher.go] Style: change log style of push status and unnecessary break - Part 1 of RTEE [dispatcher.go] Change log style of push status and unnecessary break - Part 1 of RTEA Sep 13, 2022
dispatcher/dispatcher.go Outdated Show resolved Hide resolved
dispatcher/dispatcher.go Outdated Show resolved Hide resolved
Copy link
Member

@simonlingoogle simonlingoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jwhui
Copy link
Member

jwhui commented Sep 15, 2022

The Develop workflow tests are failing. Is this expected?

@Vinggui
Copy link
Contributor Author

Vinggui commented Sep 15, 2022

The Develop workflow tests are failing. Is this expected?

@jwhui I had a similar problem recently exactly on the same place. I thought that this could be the problem, but what I've tried didn't work. It was failing because of an old golangci-lint version being used. exportloopref Is causing this error at:

golangci-lint run -E goimports -E whitespace -E goconst -E exportloopref -E unconvert --fix bindata.go

At this link https://golangci-lint.run/usage/install/ we can see how to fix it.

# binary will be $(go env GOPATH)/bin/golangci-lint
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.49.0

golangci-lint --version

simonlingoogle and others added 11 commits October 20, 2022 21:04
This commit fixes pretty issues:
- Install `shfmt` by `go install mvdan.cc/sh/v3/cmd/shfmt@latest`.
- Upgrade `golangci-lint` to v1.51.2
Bumps [wheel](https://github.com/pypa/wheel) from 0.34.2 to 0.38.1.
- [Release notes](https://github.com/pypa/wheel/releases)
- [Changelog](https://github.com/pypa/wheel/blob/main/docs/news.rst)
- [Commits](pypa/wheel@0.34.2...0.38.1)

---
updated-dependencies:
- dependency-name: wheel
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…openthread#478)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.0.0-20201021035429-f5854403a974 to 0.7.0.
- [Release notes](https://github.com/golang/net/releases)
- [Commits](https://github.com/golang/net/commits/v0.7.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
simonlingoogle and others added 9 commits March 7, 2023 09:15
* upgrade python version
* use setuptools==67.5.1
* use ubuntu-22.04
Bumps [openthread](https://github.com/openthread/openthread) from `d48799d` to `d2d9aff`.
- [Commits](openthread/openthread@d48799d...d2d9aff)

---
updated-dependencies:
- dependency-name: openthread
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [openthread](https://github.com/openthread/openthread) from `d2d9aff` to `3a688cb`.
- [Commits](openthread/openthread@d2d9aff...3a688cb)

---
updated-dependencies:
- dependency-name: openthread
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [openthread](https://github.com/openthread/openthread) from `d2d9aff` to `1f1a826`.
- [Commits](openthread/openthread@d2d9aff...1f1a826)

---
updated-dependencies:
- dependency-name: openthread
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [openthread](https://github.com/openthread/openthread) from `1f1a826` to `fa6824c`.
- [Commits](openthread/openthread@1f1a826...fa6824c)

---
updated-dependencies:
- dependency-name: openthread
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants