[script] refactor bootstrap and make-raspbian.bash
#67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmnotran
changed the title
bootstrap and make-raspbian.bash
lmnotran
force-pushed
the
feature/use-host-dns-configuration-in-rpi-qemu
branch
from
c5f54e2
to
c23d70c
Compare
This is necessary for environments which block public DNS, such as in some corporate networks. The host-machine's DNS configuration is not included in the output raspios image.
lmnotran
force-pushed
the
feature/use-host-dns-configuration-in-rpi-qemu
branch
2 times, most recently
from
3381a5a
to
48cfce8
Compare
lmnotran
commented
Aug 15, 2023
|
|
||
| # Mount /etc/resolv.conf | ||
| if [ -f "/etc/resolv.conf" ]; then | ||
| sudo mount -o ro,bind /etc/resolv.conf "$QEMU_ROOT"/etc/resolv.conf |
There was a problem hiding this comment.
This is necessary for environments which block public DNS, such as in some corporate networks.
The host-machine's DNS configuration is not included in the output raspios image. Instead, the original /etc/resolv.conf from the raspios .img will be present in the output image
lmnotran
force-pushed
the
feature/use-host-dns-configuration-in-rpi-qemu
branch
2 times, most recently
from
7ff3e71
to
48cfce8
Compare
lmnotran
force-pushed
the
feature/use-host-dns-configuration-in-rpi-qemu
branch
3 times, most recently
from
fd86d19
to
a22b3ed
Compare
bertoldi-silabs
approved these changes
Aug 18, 2023
lmnotran
force-pushed
the
feature/use-host-dns-configuration-in-rpi-qemu
branch
3 times, most recently
from
e562796
to
2f31c9e
Compare
- Rename `repo_dir` to `OT_REFERENCE_RELEASE` - Move raspios download into `make-raspbian.bash` instead of `bootstrap.bash` - Add support for x-zipped raspios images - Use DOCKER env var from host machine when running `script/otbr-setup.bash` in QEMU machine
`script/otbr-setup.bash` should fail and exit if there's a problem running `script/setup`
lmnotran
force-pushed
the
feature/use-host-dns-configuration-in-rpi-qemu
branch
from
2f31c9e
to
33bc086
Compare
|
@jwhui please review when you get a chance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
script/bootstrap.bashI think the bootstrap script was originally taken from https://github.com/openthread/ot-br-posix/blob/main/tests/scripts/bootstrap.sh.
Most of the script isn't required since the OTBR build occurs in the mounted Raspberry Pi OS
chroot, not the host machine. Within the Raspberry Pi OSchroot, the OTBR requirements are already being installed inscript/otbr-setup.bashThis PR removes most of the unnecessary packages and also makes the bootstrap script more flexible, allowing smaller portions of the script to be run via command line arguments
Also, the download of RaspiOS has been moved to
script/make-raspbian.bashscript/make-raspbian.bashcleanup()has been refactored$QEMU_ROOTare killed before unmounting/etc/resolv.confis mounted from the host into$QEMU_ROOT./etc/resolv.conffrom the raspios .img will be present in the output image