Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[script] perserving the permission when cp openthread files #95

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

superwhd
Copy link
Contributor

@superwhd superwhd commented Oct 18, 2024

In some environments, cp may produce files which have different permissions from the source files. This can fail the build of OTBR. Hence we need to add -p option in the command to preserve the permissions.

@superwhd superwhd added the bug Something isn't working label Oct 18, 2024
Copy link
Contributor

@sunytt sunytt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you update the CHANGELOG to mention this change?

@superwhd
Copy link
Contributor Author

superwhd commented Oct 18, 2024

LGTM, could you update the CHANGELOG to mention this change?

I'm inclined to not adding this to CHANGELOG because it's a small bug fix. There seem no similar changes in CHANGELOG so far.

@superwhd superwhd requested a review from jwhui October 18, 2024 04:42
@jwhui jwhui merged commit d1651ac into openthread:main Oct 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants