Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android Sample: vp9 stride value fix #490

Merged
merged 6 commits into from
Jan 9, 2024
Merged

Android Sample: vp9 stride value fix #490

merged 6 commits into from
Jan 9, 2024

Conversation

IGitGotIt
Copy link
Contributor

vp9 subscriber frames were not being rendered properly.

@goncalocostamendes goncalocostamendes self-requested a review January 8, 2024 21:10
goncalocostamendes
goncalocostamendes requested changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@goncalocostamendes goncalocostamendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Live-Photo-Capture-Kotlin is failing to build. Seems to be related with your changes.

jintgeorge
jintgeorge approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@jintgeorge jintgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goncalocostamendes goncalocostamendes self-requested a review January 9, 2024 10:18
goncalocostamendes
goncalocostamendes approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@goncalocostamendes goncalocostamendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@IGitGotIt
frame buffer size checks added, just in case.
61e4eb7 
Also it will be compatible with SDK checks
jintgeorge
jintgeorge approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@jintgeorge jintgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@IGitGotIt IGitGotIt merged commit be9fac2 into main Jan 9, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goncalocostamendes goncalocostamendes goncalocostamendes approved these changes

@jintgeorge jintgeorge jintgeorge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IGitGotIt @jintgeorge @goncalocostamendes