Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: FiX for CI, issue with docker id collision #1030

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

B-a-S
Copy link
Collaborator

@B-a-S B-a-S commented Oct 8, 2024

What

Solving collision issue with a place of docker id file and issue with running sshd

Why ?

CI fail

@B-a-S B-a-S force-pushed the master branch 2 times, most recently from 54cf8f2 to e99a5e8 Compare October 8, 2024 16:19
@B-a-S B-a-S changed the title FiX for CI, issue with docker id collision [Don't merge !!!] CI: FiX for CI, issue with docker id collision [Don't merge !!!] Oct 10, 2024
@B-a-S B-a-S changed the title CI: FiX for CI, issue with docker id collision [Don't merge !!!] CI: FiX for CI, issue with docker id collision Oct 10, 2024
.ci/job_matrix.yaml Show resolved Hide resolved
.ci/scripts/run_docker.sh Outdated Show resolved Hide resolved
@B-a-S B-a-S force-pushed the master branch 2 times, most recently from 42de9bf to bbf7850 Compare October 10, 2024 13:10
Copy link

@celermajer celermajer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is very good !!
Now if sshd failed the container stops and sleep infinity is not called 👍

@artemry-nv
Copy link
Collaborator

Make sure CI passes before we merge this PR.

@B-a-S B-a-S force-pushed the master branch 4 times, most recently from 52f2c98 to cadd727 Compare October 11, 2024 18:54
@artemry-nv artemry-nv merged commit 5d1f707 into openucx:master Oct 15, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants