UCM/CUDA: Added support for device-side variables. #10237
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosefe
reviewed
Oct 17, 2024
Comment on lines
+239
to
+243
| /** | ||
| * cudaGetSymbolAddress is in ucm_cuda_driver_funcs list because | ||
| * hook for cuModuleGetGlobal doesn't intercept cudaGetSymbolAddress call. | ||
| * */ | ||
| UCM_CUDA_FUNC_ENTRY(cudaGetSymbolAddress), |
There was a problem hiding this comment.
why not place it in runtime_api_hooks? we install both driver and runtime hooks anyway..
There was a problem hiding this comment.
We install driver and runtime hooks only if UCX_MEM_CUDA_HOOK_MODE=reloc. We install only driver hooks by default.
There was a problem hiding this comment.
maybe make some changes in the hooks logic or array names then? it seems weird that a runtime function is in the "driver" API list
src/ucm/cuda/cudamem.h
Outdated
| @@ -49,5 +49,6 @@ cudaError_t ucm_cudaMallocFromPoolAsync(void **devPtr, size_t size, | |||
| cudaMemPool_t memPool, | |||
| cudaStream_t hStream); | |||
| #endif | |||
| cudaError_t ucm_cudaGetSymbolAddress(void **devPtr, const void *symbol); | |||
There was a problem hiding this comment.
maybe move it before ucm_cudaMallocAsync hooks?
|
shall we add some unit tests for this? |
|
/azp run UCX PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added hook for
cudaGetSymbolSizeto support device-side variables.