AZP: Log warning instead of error if no CUDA device found #10242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michal-shalev
approved these changes
Oct 20, 2024
|
Do we have a way to ensure that we do have GPU devices on machines that should have it, so we don't miss testing coverage? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Cosmetic: change the logging level from error to warning if no CUDA device is available.
Why ?
If CUDA device was not found, UCX is configured with no CUDA:
https://github.com/openucx/ucx/blob/master/buildlib/jucx/jucx-test.yml#L39
It's expected in some cases, as we currently do not have ARM machines with GPU.