Tests For write_map and read_map #9
Conversation
| @@ -0,0 +1,9 @@ | |||
| FROM ubuntu:latest | |||
There was a problem hiding this comment.
What's this dockerfile for?
There was a problem hiding this comment.
This Dockerfile is for python image needed for running the task.
| @@ -0,0 +1,25 @@ | |||
| version 1.0 | |||
| import "map_workflow.wdl" as map_wdl | |||
There was a problem hiding this comment.
Misleading name? The map_workflow.wdl doesn't seem to contain a workflow
There was a problem hiding this comment.
Ooof, you are right. Let me get this fixed.
| output { | ||
| File out_file_str = write_map.out1 | ||
| File out_file_int = write_map.out2 | ||
| File out_file_bool = write_map.out3 |
There was a problem hiding this comment.
It looks like you're trying to match the spacing, in which case you need one extra space on this line
| # Dan change: add serialization for | ||
| # type Map[File, Int] and Map[File, Bool] | ||
| # to make write_map more comprehensive |
There was a problem hiding this comment.
Not sure if this comment is still relevant?
| @@ -0,0 +1,3 @@ | |||
| /cromwell-executions/wf/c7e3bd7d-b00d-444e-8b3a-3fc0223d50d0/call-write_map/inputs/456912983/f1 alice | |||
There was a problem hiding this comment.
These files are not going to be on the same path in future runs. And in cloud runs these will be totally different.
If I were you I'd make these maps more deterministic by using something like Map[String, Int], rather than using the non-deterministic File
There was a problem hiding this comment.
Got it. I shall change my test cases to something more deterministic.
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "final_workflow_outputs_dir": "./tests/test_map_serialization/tests/data/workflow_output/" | |||
There was a problem hiding this comment.
workflow_options.json: is this (Cromwell) engine specific?
No need for Dockerfile; WDL pulls from image hub already.
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "final_workflow_outputs_dir": "./tests/test_map_serialization/tests/data/output_workflow" | |||
There was a problem hiding this comment.
Is this file actually used?
| @@ -0,0 +1,3 @@ | |||
| f1 alice | |||
There was a problem hiding this comment.
Is this file ever used?
| @@ -0,0 +1,3 @@ | |||
| f1 true | |||
There was a problem hiding this comment.
This file looks like an output from a workflow run that can be deleted
| @@ -0,0 +1,3 @@ | |||
| f1 1 | |||
There was a problem hiding this comment.
This file looks like an output from a workflow run that can be deleted
Tests for write_map and read_map. pytest is having issues with md5sum, but the workflow output and expected output matches.