Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Sprocket GitHub Action in CI #13

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Conversation

adthrasher
Copy link
Contributor

Update the Sprocket lint in the workflow to use the public Sprocket GitHub Action.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • Make sure your code validates (womtool validate or miniwdl check).
  • Ensure the test suite passes.
  • Documentation is updated.
  • CHANGELOG.md is updated.
  • .dockstore.yml is updated.
  • README.md is updated.

@adthrasher adthrasher changed the title Patch 1 Use Sprocket GitHub Action in CI Oct 23, 2024
@claymcleod
Copy link

I wonder if we should also update the PR checklist to include the code passing the sprocket lints?

@adthrasher
Copy link
Contributor Author

@vsmalladi - I can't request a review from you, so tagging to make sure this isn't missed. We've published a GitHub Action to wrap Sprocket's check and lint functionality.

@vsmalladi vsmalladi self-requested a review October 23, 2024 17:38
Copy link
Collaborator

@vsmalladi vsmalladi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsmalladi
Copy link
Collaborator

Merge when ready.

@adthrasher
Copy link
Contributor Author

@vsmalladi - I don't have permission to merge.

@vsmalladi vsmalladi merged commit bd70cd8 into openwdl:main Oct 23, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants