Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix crash when clear ui commands without commands. #651

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

andycall
Copy link
Member

@andycall andycall commented Aug 21, 2024

Fix an crash reported by one of our primary customers.

Build fingerprint: 'HUAWEI/ALN-AL00/HWALN:12/HUAWEIALN-AL00/104.0.0.165C00:user/release-keys'
#00 0x00000000000db92c /data/app/~~Dn3YtAsInOgqKCZP4g==/Q==/lib/arm64/libwebf.so (BuildId: 0c7f3e4f445ad0da05101c741e1fa30e1e686bec)
                                                                                                                               webf::UICommandBuffer::clear()
                                                                                                                               webf/bridge/foundation/ui_command_buffer.cc:128:46
#01 0x00000000000d5b54 /data/app/~~tAYRj4sInOgqKCZP4g==/4SM56a8_ZSWPTzKpQ==/lib/arm64/libwebf.so (BuildId: 0c7f3e4f445ad0da05101c741e1fa30e1e686bec)
                                                                                                                               webf::SharedUICommand::clear()
                                                                                                                               webf/bridge/foundation/shared_ui_command.cc:57:18
#02 0x00000000000ebdd4 /data/app/~~DAYRj4sInOgqKCZP4g==/K3c4SM56a8_ZSWPTzKpQ==/lib/arm64/libwebf.so (clearUICommandItems+16) (BuildId: 0c7f3e4f445ad0da05101c741e1fa30e1e686bec)
                                                                                                                               clearUICommandItems
                                                                                                                               webf/bridge/webf_bridge.cc:307:48

@andycall andycall force-pushed the fix/crash_when_clear_commands branch from 64648e4 to ad2afa5 Compare September 9, 2024 08:32
@andycall andycall force-pushed the fix/crash_when_clear_commands branch from ad2afa5 to b3238cd Compare October 8, 2024 07:18
@andycall andycall merged commit de89354 into main Oct 9, 2024
31 of 32 checks passed
@andycall andycall deleted the fix/crash_when_clear_commands branch October 9, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants