Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization to put LHS operand in registers for WGMMA before elementwise ops #17

Closed
wants to merge 28 commits into from
Closed

Optimization to put LHS operand in registers for WGMMA before elementwise ops #17

wants to merge 28 commits into from
+657 −143

Commits on Sep 19, 2024

  1. preliminary changes for hoisting DotOpEnc for MMAV3

    @ggengnv
    ggengnv committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    30787ef View commit details
    Browse the repository at this point in the history

  2. improve DotOpEnc hoisting to use LocalLoad

    @ggengnv
    ggengnv committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    896e128 View commit details
    Browse the repository at this point in the history

  3. Don't pipeline LHS operand for now

    @ggengnv
    ggengnv committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    07552f4 View commit details
    Browse the repository at this point in the history

  4. Add placeholders for SharedToDotOpV3 and fix LLVM lowering issues

    @ggengnv
    ggengnv committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    60b08ca View commit details
    Browse the repository at this point in the history

  5. Hack to make SharedEncodingAttr work for different width types

    @ggengnv
    ggengnv committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ec5a726 View commit details
    Browse the repository at this point in the history

  6. dot lower to shared working for Hopper; small refactors

    @ggengnv
    ggengnv committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    d4ae449 View commit details
    Browse the repository at this point in the history

  7. Fix dot op ordering for WGMMA and allow ConstantOp

    @ggengnv
    ggengnv committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    fefdabc View commit details
    Browse the repository at this point in the history

  8. Revert DecomposeUnsupportedConversions since we use v2 SharedEnc for … 

    …wgmma
    @ggengnv
    ggengnv committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    5767cf3 View commit details
    Browse the repository at this point in the history

  9. revert ordering changes

    @ggengnv
    ggengnv committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a72548f View commit details
    Browse the repository at this point in the history

  10. i8 -> f16 working

    @ggengnv
    ggengnv committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    0c3b0a8 View commit details
    Browse the repository at this point in the history

  11. fix lit test regressions

    @ggengnv
    ggengnv committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a8875b0 View commit details
    Browse the repository at this point in the history

  12. Add comments for isHopperWidthChange

    @ggengnv
    ggengnv committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    38d6f45 View commit details
    Browse the repository at this point in the history

  13. fix regression for Hopper MMA > DotOp

    @ggengnv
    ggengnv committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    9c36d4e View commit details
    Browse the repository at this point in the history

  14. Disable hoisting thru downcasts

    @ggengnv
    ggengnv committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    0568fd8 View commit details
    Browse the repository at this point in the history

  15. fix test regression with WGMMA.cpp

    @ggengnv
    ggengnv committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a3d65d1 View commit details
    Browse the repository at this point in the history

  16. Rewrite OptimizeDotOperands logic to fix for general case

    @ggengnv
    ggengnv committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    bbb0668 View commit details
    Browse the repository at this point in the history

  17. fix another regression and add minor comments

    @ggengnv
    ggengnv committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    00418d6 View commit details
    Browse the repository at this point in the history

  18. Remove redundant LocalAlloc+LocalLoad ops added in OptimizeDotOperands

    @ggengnv
    ggengnv committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    93ef960 View commit details
    Browse the repository at this point in the history

  19. fix bad rebase

    @ggengnv
    ggengnv committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    3c65087 View commit details
    Browse the repository at this point in the history

  20. Pipelining

    @ggengnv
    ggengnv committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    e7904ee View commit details
    Browse the repository at this point in the history

  21. Add pipeline test

    @ggengnv
    ggengnv committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    d67b207 View commit details
    Browse the repository at this point in the history

  22. Add chained test for dot operand hoisting

    @ggengnv
    ggengnv committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    bbea8d6 View commit details
    Browse the repository at this point in the history

  23. Fix hoisting bug and add comments

    @ggengnv
    ggengnv committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    d1b64ee View commit details
    Browse the repository at this point in the history

  24. delete draft code

    @ggengnv
    ggengnv committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    1115cd2 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Improve comments

    @ggengnv
    ggengnv committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    15e9cf6 View commit details
    Browse the repository at this point in the history

  2. Fix coalescing

    @ggengnv
    ggengnv committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    47f1e84 View commit details
    Browse the repository at this point in the history

  3. fix typo

    @ggengnv
    ggengnv committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a2dea0a View commit details
    Browse the repository at this point in the history

  4. More minor comments

    @ggengnv
    ggengnv committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    c3460a3 View commit details
    Browse the repository at this point in the history