Use ModuleHandle for module state tracking #18303
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_685849586
branch
from
a36bd94
to
c0bf696
Compare
We used to use void pointers to identify loaded GPU binaries. This change makes it use the `ModuleHandle` type. It avoids a bunch of `reinterpret_cast` and makes it also more clear what the void pointer represents. In addition this is replacing the out parameters in a bunch of related functions by `absl::StatusOr<...>` return types. PiperOrigin-RevId: 685849586
copybara-service
bot
force-pushed
the
test_685849586
branch
from
c0bf696
to
2e20dba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ModuleHandle for module state tracking
We used to use void pointers to identify loaded GPU binaries. This change makes it use the
ModuleHandletype. It avoids a bunch ofreinterpret_castand makes it also more clear what the void pointer represents.In addition this is replacing the out parameters in a bunch of related functions by
absl::StatusOr<...>return types.