-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add redhat 9 build and package #515
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this is a draft... I'm not sure if that's intentional but fyi it lgtm.
.github/actions/openziti-tunnel-build-action/redhat-9/entrypoint.sh
Outdated
Show resolved
Hide resolved
21e40b6
to
90b0a63
Compare
Draft pending resolution of related issue |
b59f0b7
to
04fa443
Compare
04fa443
to
055339d
Compare
055339d
to
7ca2671
Compare
Nice! fyi you can link to an issue in a PR just by typing "fixes" and then the issue number preceded by a pound sign. Actually there are lots of ways to do this. When thusly linked, the issue is automatically closed when the PR is merged. |
Can you verify that we're dynamically linking with the ssl libraries from the system? |
On RHEL9, which resolver works currently on the default OS config? Does RHEL9 enable systemd-resolved by default? |
Here are the dynamic links for [root@rocky9 ~]# ldd /opt/openziti/bin/ziti-edge-tunnel
linux-vdso.so.1 (0x00007fff83f75000)
libz.so.1 => /lib64/libz.so.1 (0x00007f15fd370000)
libatomic.so.1 => /lib64/libatomic.so.1 (0x00007f15fd367000)
libm.so.6 => /lib64/libm.so.6 (0x00007f15fd28c000)
libresolv.so.2 => /lib64/libresolv.so.2 (0x00007f15fd278000)
libc.so.6 => /lib64/libc.so.6 (0x00007f15fd000000)
/lib64/ld-linux-x86-64.so.2 (0x00007f15fd38f000) |
Is that image used by the cpack workflow? |
The A step is required after installing the RPM to configure Ziti DNS, e.g., running - name: Add two IPv4 DNS server addresses
community.general.nmcli:
conn_name: eth0
type: ethernet
dns4_ignore_auto: true
dns4:
- 100.64.0.2
- 1.1.1.1
state: present |
This branch is up to date with brain |
Ok. We need to figure out why the build isn’t using the system ssl and z libraries. The port overlay cmake variable should cause the builds to link wilt system libraries. |
ok, I see why the dynamic ssl libraries aren't being linked... duh... it's because we (actually I) switched the default back to mbedtls in #663 when we saw the chain verification surprises with openssl recently. Also the cmake variable that controls the crypto libs have changed, and so the build for rh9 lgtm. |
.github/actions/openziti-tunnel-build-action/redhat-9/entrypoint.sh
Outdated
Show resolved
Hide resolved
significant differences after review
No description provided.