process CA bundle event #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- re-write config file or external CA bundle file
smilindave26
approved these changes
Sep 13, 2023
scareything
approved these changes
Sep 13, 2023
|
|
||
| int rc = 0; | ||
| uv_fs_t fs_req = {0}; | ||
| CHECK_UV("check exiting config", uv_fs_stat(NULL, &fs_req, path, NULL)); |
There was a problem hiding this comment.
check existing. btw this typo is also pre-existing on line 1232.
also should "config" be changed to "file" in this function?
|
|
||
| if (write_new_cfg) { |
There was a problem hiding this comment.
seems like a good place for a log. maybe even at INFO?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[fixed #721]