Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IFC-29 Convert account node to use a generic #3807

Merged
merged 27 commits into from
Jul 26, 2024
Merged

Conversation

gmazoyer
Copy link
Contributor

This PR addresses the work described in IFC-29.

A generic for account is now created with a node that inherits from it. It provides the same level of feature as before but the generic allow users to define their own account nodes.

@gmazoyer gmazoyer added the type/feature New feature or request label Jul 10, 2024
@github-actions github-actions bot added group/backend Issue related to the backend (API Server, Git Agent) group/python-sdk labels Jul 10, 2024
Copy link

codspeed-hq bot commented Jul 10, 2024

CodSpeed Performance Report

Merging #3807 will not alter performance

Comparing gma-20240709-ifc29 (4602cd6) with develop (e04ca98)

Summary

✅ 10 untouched benchmarks

@gmazoyer gmazoyer force-pushed the gma-20240709-ifc29 branch 4 times, most recently from 8bd1b01 to a9e9766 Compare July 16, 2024 07:59
@github-actions github-actions bot added the group/frontend Issue related to the frontend (React) label Jul 16, 2024
@github-actions github-actions bot added the type/documentation Improvements or additions to documentation label Jul 17, 2024
@gmazoyer gmazoyer force-pushed the gma-20240709-ifc29 branch 2 times, most recently from 8b0579e to 26dca7f Compare July 18, 2024 15:55
@gmazoyer gmazoyer marked this pull request as ready for review July 18, 2024 16:12
@gmazoyer gmazoyer changed the title Convert account node to use a generic IFC-29 Convert account node to use a generic Jul 22, 2024
@gmazoyer gmazoyer requested review from a team July 25, 2024 10:25
@gmazoyer gmazoyer merged commit d0dca10 into develop Jul 26, 2024
46 checks passed
@gmazoyer gmazoyer deleted the gma-20240709-ifc29 branch July 26, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent) group/frontend Issue related to the frontend (React) type/documentation Improvements or additions to documentation type/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants