Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #4564 #4565

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Closes #4564 #4565

wants to merge 2 commits into from
+411 −0

Conversation

lpconsulting321
Copy link

@lpconsulting321 lpconsulting321 commented Oct 7, 2024 •
edited by BeArchiTek
Loading

This schema should encompass the Slurpit model from Slurpit V1.1.3, as it includes support for sites.

Closes #4564

@lpconsulting321 lpconsulting321 marked this pull request as draft October 7, 2024 21:26
@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Oct 7, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Oct 7, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

lpconsulting321 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@lpconsulting321 lpconsulting321 mentioned this pull request Oct 7, 2024
Open
@BeArchiTek BeArchiTek self-requested a review October 10, 2024 13:27
@BeArchiTek BeArchiTek added type/documentation Improvements or additions to documentation ci/skip-changelog Don't include this PR in the changelog type/task Body of work related to an epic labels Oct 10, 2024
@lpconsulting321 lpconsulting321 marked this pull request as ready for review October 23, 2024 16:11
@lpconsulting321 lpconsulting321 changed the title WIP: Closes #4564 Closes #4564 Oct 23, 2024
BeArchiTek
BeArchiTek requested changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@BeArchiTek BeArchiTek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This schema is working as it is, but we are currently deprecating the default_filter to use uniquess_constraint and human_friendly_id instead. could I asked you to change those first ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeArchiTek BeArchiTek BeArchiTek requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
ci/skip-changelog Don't include this PR in the changelog type/documentation Improvements or additions to documentation type/task Body of work related to an epic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: Add Slurpit Example Schema
2 participants
@lpconsulting321 @BeArchiTek