Add support for additional context to the metrics for query execution time #4662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
dgarros
force-pushed
the
dga-20241018-metric-context
branch
from
7ff2cc9
to
4665c16
Compare
github-actions
bot
added
type/documentation
ogenstad
approved these changes
Oct 25, 2024
| for idx, (key, value) in enumerate(context.items()) | ||
| if idx <= 1 | ||
| } | ||
| ) |
There was a problem hiding this comment.
Will context contain more that two keys and if so does it matter if they are ordered or not?
There was a problem hiding this comment.
it shouldn't have more than 2 keys and the order doesn't matter as long as it's consistent
dgarros
force-pushed
the
dga-20241018-metric-context
branch
from
4665c16
to
0e78474
Compare
github-actions
bot
removed
type/documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extend the QUERY_EXECUTION metric to support 2 additional (optional) dimensions.
Because each query may have different information to report, the name of these dimensions is very generic (context1 & context2)
As an example,
The query
node_constraints_uniquenesshas been updated to leverage this new capability to report the kind of the node as well. Having this information in prometheus is really important to understand how thenode_constraints_uniquenessquery is performing based on the information we have in the schema