Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all the references of default_filter to human_friendly_id #4682

Closed
wants to merge 8 commits into from

Conversation

vsurresh
Copy link
Contributor

No description provided.

Copy link

cla-assistant bot commented Oct 22, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Oct 22, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


“suresh” seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@vsurresh
Copy link
Contributor Author

Changed all the references from 'default_filter' to 'human_friendly_id: ["name__value"]'

PS - Assign it to petercrocker

@petercrocker petercrocker requested a review from a team October 22, 2024 14:17
@@ -275,7 +275,7 @@ nodes:
description: "A Circuit represent a single physical link between two locations"
label: "Circuit"
icon: "mdi:transit-connection-variant"
default_filter: circuit_id__value
human_friendly_id: ["name__value"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think circuit has a name, guess it should be "circuit_id__value"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've amended now

@@ -242,7 +242,7 @@ nodes:
description: "A Circuit represent a single physical link between two locations"
label: "Circuit"
icon: "mdi:transit-connection-variant"
default_filter: circuit_id__value
human_friendly_id: ["name__value"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the above, it should be circuit_id__value

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BaptisteGi I've changed them all now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems they're correct for every one but this one on line 245 of netbox.yml?

@dgarros dgarros changed the title Default filter Changed all the references of default_filter to human_friendly_id Oct 23, 2024
@dgarros dgarros changed the title Changed all the references of default_filter to human_friendly_id Change all the references of default_filter to human_friendly_id Oct 23, 2024
@wvandeun wvandeun changed the base branch from stable to release-1.0 October 27, 2024 22:53
@wvandeun wvandeun force-pushed the default_filter branch 2 times, most recently from 4eef597 to 1682484 Compare October 28, 2024 14:43
@wvandeun
Copy link
Contributor

Still need to test infrahub-sync with updated netbox/nautobot schema

@wvandeun wvandeun marked this pull request as draft October 30, 2024 21:13
@lykinsbd lykinsbd deleted the branch opsmill:release-1.0 October 31, 2024 03:11
@lykinsbd lykinsbd closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants