Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DiffAllPathsQuery benchmark #4740

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Add DiffAllPathsQuery benchmark #4740

merged 1 commit into from
Oct 28, 2024

Conversation

LucasG0
Copy link
Contributor

@LucasG0 LucasG0 commented Oct 25, 2024

This PR adds a benchmark for DiffAllPathsQuery, based on a dedicated data generator CarWithDiffInSecondBranchGenerator mainly responsible for:

  • Loading cars in main branch
  • Rebasing diff branch on main branch
  • Loading changes (attributes/relationships updates, adding new cars) in diff branch

Note that schema/DataGenerator are still not part of BenchmarkConfig. I think DataGenerator used for benchmarking might be too close to logic of the test (mainly, the query used) to be defined within BenchmarkConfig. We could discuss that at some point @dgarros and I might submit another PR for this.

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Oct 25, 2024
@LucasG0 LucasG0 requested a review from a team October 28, 2024 08:09
@LucasG0 LucasG0 merged commit fad721d into develop Oct 28, 2024
31 checks passed
@LucasG0 LucasG0 deleted the lgu-diff-benchmark branch October 28, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants